Maor Lipchuk has posted comments on this change.
Change subject: core: Fixing NPE in case of endCommand failure
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 263: memoryVolume,
createdSnapshot.getId());
Line 264: }
Line 265: }
Line 266: } else {
Line 267: log.infoFormat("No snapshot was created for
VM {0} which is in LOCKED status", getVmId());
I would change this to warn or error. perhaps warn is more suitable
Line 268: }
Line 269: }
Line 270:
Line 271: incrementVmGeneration();
--
To view, visit http://gerrit.ovirt.org/16644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78a617f43bd297db13b7dc9ad6649b67c773c144
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
