ofri masad has posted comments on this change.
Change subject: core: Add vnic profiles to DB and entities
......................................................................
Patch Set 28: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
Line 86: return result;
Line 87: }
Line 88:
Line 89: @Override
Line 90: public boolean equals(Object obj) {
you can use ObjectTools.objectsEqual for each field instead of this auto
generated.
Line 91: if (this == obj) {
Line 92: return true;
Line 93: }
Line 94: if (obj == null) {
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileDaoDbFacadeImpl.java
Line 84:
Line 85: @Override
Line 86: public VnicProfile mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 87: VnicProfile entity = new VnicProfile();
Line 88:
entity.setId(Guid.createGuidFromString(rs.getString("id")));
you can use getGuid(ResultSet, String) to parse Guid with better performance
Line 89: entity.setName(rs.getString("name"));
Line 90:
entity.setNetworkId(Guid.createGuidFromString(rs.getString("network_id")));
Line 91:
entity.setCustomProperties(rs.getString("custom_properties"));
Line 92: entity.setPortMirroring(rs.getBoolean("port_mirroring"));
Line 86: public VnicProfile mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 87: VnicProfile entity = new VnicProfile();
Line 88:
entity.setId(Guid.createGuidFromString(rs.getString("id")));
Line 89: entity.setName(rs.getString("name"));
Line 90:
entity.setNetworkId(Guid.createGuidFromString(rs.getString("network_id")));
same
Line 91:
entity.setCustomProperties(rs.getString("custom_properties"));
Line 92: entity.setPortMirroring(rs.getBoolean("port_mirroring"));
Line 93: return entity;
Line 94: }
--
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
