Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py
Line 51: if added:
Line 52: line += '<osetup_add>{added}</osetup_add>'.format(
Line 53: added=added,
Line 54: )
Line 55: return line
the problem is that if we do not settle this before release we will never be
able to. I do prefer to use the index for that, not sure I understand the
complexity, can you share your thoughts?
Line 56:
Line 57: def createGroup(self, group, description, optional):
Line 58: self.environment.setdefault(
Line 59: osetupcons.CoreEnv.FILE_GROUP_PREFIX + group,
--
To view, visit http://gerrit.ovirt.org/16768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ab434de8fb675c67ac5d1907879e465e587dbf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
