Alon Bar-Lev has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 681: formattedISOversion =
formattedISOversion.substring(formattedISOversion.length() - 8);
Line 682: Date dateISO =
dateISOformat.parse(formattedISOversion);
Line 683: // Split by . nodeInfo[2] and get the first element.
Example: 20120228.fc18
Line 684: Date dateNodeISO =
dateISOformat.parse(nodeInfo[2].split("\\.")[0].trim()); //$NON-NLS-1$
Line 685: if (dateISO.compareTo(dateNodeISO)>0) {
stupid question after all these reviews...
why not just compare the version as-is? the date should be meaningless.
Line 686: alert = true;
Line 687: break;
Line 688: }
Line 689: } catch (RuntimeException ex) {
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
