Martin Peřina has uploaded a new change for review. Change subject: tools: Fix ovirt-engine-notifier logging config ......................................................................
tools: Fix ovirt-engine-notifier logging config Fixes ovirt-engine-noitifier logging config under JBoss EAP. The problem started when JBoss EAP reimplemented log4j classes in JBoss Log Manager, but logging configuration initialization from system property log4j.configuration has not been included in those reimplemented classes. This patch initializes log4j configuration for ovirt-engine-notifier. Change-Id: Iad46dc04853e87e280c2f60100a041d781809eb8 Bug-Url: https://bugzilla.redhat.com/948744 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/17051/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java index 5972e6a..dff895d 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java @@ -1,6 +1,8 @@ package org.ovirt.engine.core.notifier; import java.net.InetAddress; +import java.net.MalformedURLException; +import java.net.URL; import java.util.ArrayList; import java.util.List; import java.util.concurrent.Executors; @@ -9,9 +11,12 @@ import java.util.concurrent.TimeUnit; import javax.mail.internet.InternetAddress; +import javax.xml.parsers.FactoryConfigurationError; import org.apache.commons.lang.StringUtils; +import org.apache.log4j.LogManager; import org.apache.log4j.Logger; +import org.apache.log4j.xml.DOMConfigurator; import org.ovirt.engine.core.notifier.utils.NotificationProperties; import sun.misc.Signal; @@ -28,10 +33,27 @@ private static ScheduledExecutorService monitorScheduler = Executors.newSingleThreadScheduledExecutor(); /** + * Initializes logging configuration + */ + private static void initLogging() { + String cfgFile = System.getProperty("log4j.configuration"); + if (StringUtils.isNotBlank(cfgFile)) { + try { + URL url = new URL(cfgFile); + LogManager.resetConfiguration(); + DOMConfigurator.configure(url); + } catch (FactoryConfigurationError | MalformedURLException ex) { + System.out.println("Cannot configure logging: " + ex.getMessage()); + } + } + } + + /** * @param args * [0] configuration file absolute path */ public static void main(String[] args) { + initLogging(); NotifierSignalHandler handler = new NotifierSignalHandler(); Signal.handle(new Signal("HUP"), handler); handler.addScheduledExecutorService(notifyScheduler); -- To view, visit http://gerrit.ovirt.org/17051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad46dc04853e87e280c2f60100a041d781809eb8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
