Sandro Bonazzola has posted comments on this change.
Change subject: packaging: spec: avoid breaking firewalld
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File ovirt-engine.spec.in
Line 503: touch %{buildroot}%{engine_pki}/cert.template
Line 504: touch %{buildroot}%{engine_pki}/database.txt
Line 505: touch %{buildroot}%{engine_pki}/serial.txt
Line 506: #legacy firewalld
Line 507: mkdir -p %{buildroot}%{_sysconfdir}/firewalld/services
Done
Line 508: touch %{buildroot}%{_sysconfdir}/firewalld/services/ovirt.xml
Line 509:
Line 510: install -d "%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d"
Line 511: cat >
"%{buildroot}%{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf" <<
__EOF__
Line 588: %posttrans setup
Line 589: #Avoid breaking firewalld configuration on rpm upgrade.
Line 590: if [ -e %{_sysconfdir}/firewalld/services/ovirt.xml.rpmsave ] ; then
Line 591: mv %{_sysconfdir}/firewalld/services/ovirt.xml.rpmsave
%{_sysconfdir}/firewalld/services/ovirt.xml
Line 592: fi
tested without this with %ghost, seems it's working so I've removed the above.
Line 593:
Line 594:
Line 595: %post backend
Line 596:
--
To view, visit http://gerrit.ovirt.org/17002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb96a6bf70a3784187838b51aceff3da6ee11e95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
