Omer Frenkel has posted comments on this change.
Change subject: core: simplified memory states removal code
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
Line 56:
Line 57: Guid guid2 = removeConfImage(guids);
Line 58:
Line 59: if (startPollingTasks) {
Line 60: if (!Guid.Empty.equals(guid1)) {
why do you need to check for empty guid?
Line 61:
AsyncTaskManager.getInstance().StartPollingTask(guid1);
Line 62: }
Line 63:
Line 64: if (guid2 != null && !Guid.Empty.equals(guid2)) {
--
To view, visit http://gerrit.ovirt.org/16827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0b5b9d77458db7c2a7e97fe0d36fd2b8679d20d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
