Shubhendu Tripathi has posted comments on this change.
Change subject: engine: renamed validatePinningAndMigration to
validateMigrationRules
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
2 minor comments
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
Line 27: @Rule
Line 28: public MockConfigRule config = new MockConfigRule(new
MockConfigDescriptor<Boolean>(ConfigValues.CpuPinMigrationEnabled,
Line 29: "false",
Line 30: false));
Line 31:
Remove the unwanted tabs
Line 32: @Test
Line 33: public void isCpuPinningValidWithoutPinnedHost() {
Line 34: VmManagementCommandBase<VmManagementParametersBase> test =
Line 35: spy(new
VmManagementCommandBase<VmManagementParametersBase>(Guid.Empty));
Line 139: dedicatedVds.setVdsGroupCompatibilityVersion(Version.v3_1);
Line 140:
Assert.assertTrue(test.isCpuPinningValid("10#1,2,3_11#1-20,^3", vmStatic));
Line 141:
Line 142: }
Line 143:
Remove the unwanted tabs
Line 144: @Test
Line 145: public void testValidatePinningAndMigration() {
Line 146: VmStatic vmStaticData = new VmStatic();
Line 147: vmStaticData.setAutoStartup(true);
--
To view, visit http://gerrit.ovirt.org/16292
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b8a0dca428fe2ddb0e3073667bb7980cd12b04
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
