Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Prevent SystemTree from losing selection
......................................................................
webadmin: Prevent SystemTree from losing selection
There are basically two listeners for SystemTreeModel's
ItemsChanged event:
(1) SystemTreeModelProvider.updateDataProvider
- actual listener registration code is in
DataBoundTabModelProvider.onCommonModelChange
- this method selects root "System" node
(2) SystemTree.addModelListeners
- this method de-selects last selected node
Upon WebAdmin startup, (2) gets executed after (1) which
causes SystemTree to lose selection.
As a result, code calling SystemTreeModel.getSelectedItem
might blow up on NullPointerException.
This patch ensures SystemTree doesn't lose selection upon
SystemTreeModel's ItemsChanged event.
Change-Id: Ie5c099dd6bbce0f721e7ed2430ecb7124b9241ca
Signed-off-by: Vojtech Szocs <[email protected]>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/17115/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
index 6eb44c1..78513e2 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java
@@ -92,9 +92,6 @@
modelProvider.getModel().getItemsChangedEvent().addListener(new
IEventListener() {
@Override
public void eventRaised(Event ev, Object sender, EventArgs args) {
- // Reset selection in the model
- SystemTreeItemModel lastSelectedItem =
modelProvider.getSelectionModel().getSelectedObject();
-
modelProvider.getSelectionModel().setSelected(lastSelectedItem, false);
expandTree(getDataDisplayWidget().getRootTreeNode(),
ITEM_LEVEL);
}
});
--
To view, visit http://gerrit.ovirt.org/17115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5c099dd6bbce0f721e7ed2430ecb7124b9241ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
