Omer Frenkel has posted comments on this change.
Change subject: engine: Report when vm gets less then Guaranteed memory
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1315: AuditLogableBase auditLogable = new
AuditLogableBase();
Line 1316: auditLogable.addCustomValue("VmName",
savedVm.getName());
Line 1317: auditLogable.addCustomValue("VdsName",
this._vds.getName());
Line 1318: auditLogable.addCustomValue("MemGuaranteed",
String.valueOf(savedVm.getMinAllocatedMem()));
Line 1319: auditLogable.addCustomValue("MemActual",
vmStatistics.getCurrentMemory().toString());
i think this is not in MB and in the message it say MB, no?
Line 1320: auditLog(auditLogable,
AuditLogType.VM_MEMORY_UNDER_GUARANTEED_VALUE);
Line 1321: }
Line 1322:
Line 1323: }
....................................................
Commit Message
Line 3: AuthorDate: 2013-07-16 17:52:17 +0300
Line 4: Commit: Noam Slomianko <[email protected]>
Line 5: CommitDate: 2013-07-21 12:26:36 +0300
Line 6:
Line 7: engine: Report when vm gets less then Guaranteed memory
*than
Line 8:
Line 9: Currently vm might get less then the guaranteed memory.
Line 10: In they future they will be migrated, but for now we will only log the
issue.
Line 11:
--
To view, visit http://gerrit.ovirt.org/16949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47d32f291f39f0ab51c4e5d20a34ab01b47db562
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
