Daniel Erez has posted comments on this change.
Change subject: engine: Fix potential NumberFormatException in OsRepositoryImpl
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java
Line 181: return 0;
Line 182: }
Line 183:
Line 184: private boolean getBoolean(String value, boolean defaultValue) {
Line 185: return value == null ? defaultValue :
Boolean.parseBoolean(value);
do we need a similar protection here?
Line 186: }
Line 187:
Line 188: private int getInt(String value, int defaultValue) {
Line 189: try {
--
To view, visit http://gerrit.ovirt.org/17117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ec4c9704d35b7f2955ed41761d4f019969897c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
