Mike Kolesnik has posted comments on this change.
Change subject: restapi: Don't set bootproto on VLAN attach to NIC
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java
Line 57:
network,
Line 58:
hostInterface);
Line 59: params.setBondingOptions(hostInterface.getBondOptions());
Line 60:
Line 61: if (network == null || network.getVlanId() == null) {
Well, if the REST maintainer will agree with your approach then I'm fine with
dropping these fields being set here.
My thought with this patch was to cause as less impact as possible on the
existing behaviour since there are a few cases where the behaviour could change
unexpectedly.
However, IMHO these fields shouldn't be set automatically upon action, since
its confusing to the caller of the method.
Line 62: params.setBootProtocol(hostInterface.getBootProtocol());
Line 63: params.setAddress(hostInterface.getAddress());
Line 64: params.setSubnet(hostInterface.getSubnet());
Line 65: }
--
To view, visit http://gerrit.ovirt.org/17140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78b415592e2bc1a9fea901cadb3ee928f2935a14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
