Juan Hernandez has posted comments on this change.

Change subject: core: Add external identifier to DbUser
......................................................................


Patch Set 3:

I will add the DAO tests.

I am using byte[] for the external identifier so that providers can use 
whatever they like as identifier, as long as they can convert it to an array of 
bytes. String isn't that good for this because it is expensive in terms of 
storage and performance.

-- 
To view, visit http://gerrit.ovirt.org/15749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf81ba87a178f3d275ed172e82b0036635f1a28f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to