Ori Liel has posted comments on this change.

Change subject: core: restapi: wip: introducing 
ExportDiskBySnapshotAsBlockDevice
......................................................................


Patch Set 3: (1 inline comment)

....................................................
Commit Message
Line 4: Commit:     Liron Aravot <[email protected]>
Line 5: CommitDate: 2013-07-01 19:43:06 +0300
Line 6: 
Line 7: core: restapi: wip: introducing ExportDiskBySnapshotAsBlockDevice
Line 8: 
Please add a test to rest-api as well
Line 9: *Missing tests/locks(?)
Line 10: 
Line 11: *Still debating whether it'll be pass in the command parameters image
Line 12: uuid (==volume) instead of disk id + snapshotid


-- 
To view, visit http://gerrit.ovirt.org/16284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f96c2d8f4e0507383accfceff217e9719332607
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to