Daniel Erez has uploaded a new change for review. Change subject: webadmin: refresh data on templates-disks sub-tab ......................................................................
webadmin: refresh data on templates-disks sub-tab Templates main-tab -> Disks sub-tab: ensure storage domains data refresh. Change-Id: Iea5004501dbdb1a3818e479633db5d6ba0249086 Bug-Url: https://bugzilla.redhat.com/972669 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java 1 file changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/17200/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java index 44172a3..6d5e76c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java @@ -139,19 +139,12 @@ } @Override - public void setItems(Iterable value) + public void setItems(final Iterable value) { - if (!getStorageDomains().isEmpty() || ignoreStorageDomains) - { - ArrayList<DiskImage> disks = - value != null ? Linq.<DiskImage> cast(value) : new ArrayList<DiskImage>(); - - Collections.sort(disks, new DiskByAliasComparer()); - super.setItems(disks); + if (ignoreStorageDomains) { + setDisks(value); } - else - { - this.value = value; + else { AsyncDataProvider.getStorageDomainList(new AsyncQuery(this, new INewAsyncCallback() { @Override @@ -161,7 +154,7 @@ Collections.sort(storageDomains, new NameableComparator()); setStorageDomains(storageDomains); - setItems(model.value); + setDisks(value); } })); } @@ -169,6 +162,14 @@ updateActionAvailability(); } + private void setDisks(Iterable value) { + ArrayList<DiskImage> disks = + value != null ? Linq.<DiskImage> cast(value) : new ArrayList<DiskImage>(); + + Collections.sort(disks, new DiskByAliasComparer()); + super.setItems(disks); + } + @Override protected void onSelectedItemChanged() { -- To view, visit http://gerrit.ovirt.org/17200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea5004501dbdb1a3818e479633db5d6ba0249086 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
