Alon Bar-Lev has posted comments on this change.
Change subject: API: Adding mapping between host and action parameters and
using username field
......................................................................
Patch Set 1: (1 inline comment)
Not sure I understand this code... quite complex for me...
but if rootPassword is provided I expect user to be set as root and password to
rootPassword
default user if not provided is root
default port if not provided is 22
If that is the case then I am fine!
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 553: if (action.getSsh().isSetUser()) {
Line 554: if (action.getSsh().getUser().isSetPassword()) {
Line 555: // For backward compatibility giving priority to
rootPassword field
Line 556: if (params.getPassword() == null) {
Line 557:
params.setPassword(action.getSsh().getUser().getPassword());
please also set user root
Line 558: }
Line 559: }
Line 560: if (action.getSsh().getUser().isSetUserName()) {
Line 561:
params.getvds().setSshUsername(action.getSsh().getUser().getUserName());
--
To view, visit http://gerrit.ovirt.org/17194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc7f6ba85ed6a5a790b3cc0acce3f5d6eb305789
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
