Maor Lipchuk has posted comments on this change. Change subject: core: extract method to imagesUtils ......................................................................
Patch Set 1: @Allon because then vdsbroker could not us it. Originally, CreateVmVDSCommand was also about to be changed to use this method. so for the VDS command to see it, I needed to add a new class in the utils module. After I noticed that CreateVmVDSCommand does not have to use it, I could move it back to imagesHandler, although I think this could be type of util which will not be a bad idea to add it as a utilclass, so vdsbroker can also gain from it... -- To view, visit http://gerrit.ovirt.org/17171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7700c28323908128a63910866eddb7dfa4b112fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
