Alex Lourie has posted comments on this change.
Change subject: bin: added --console command
......................................................................
Patch Set 1: (2 inline comments)
small comments
....................................................
File src/bin/hosted-engine.in
Line 120: echo "Use the password you've set using
--add-console-password for logging in"
Line 121: exec /bin/remote-viewer vnc://localhost:5900
Line 122: elif [ "${console}" == "qxl" ] ; then
Line 123: if [ ! -r "${ca_cert}" ] ; then
Line 124: echo "Missing spice PKI certificate"
I recommend we suggest a user what he can do (like something is not installed,
or...)
Line 125: exit 1
Line 126: fi
Line 127: exec /bin/remote-viewer \
Line 128: --spice-ca-file=${ca_cert} \
....................................................
File src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py
Line 83: matcher = self._RE_SUBJECT.match(line)
Line 84: if matcher is not None:
Line 85: subject = matcher.group('subject')
Line 86: break
Line 87: if subject is None:
for..else ?
Line 88: raise RuntimeError(_('Error parsing libvirt certificate'))
Line 89: self.environment[ohostedcons.VDSMEnv.SPICE_SUBJECT] = subject
Line 90:
Line 91: def _generateSPICEcerts(self):
--
To view, visit http://gerrit.ovirt.org/17114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadbcb35a07d59ed8bfc5a998ae6dbc723705eafd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
