Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: host rename
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/pki.py
Line 81: note=_('Do you want to continue? (@VALUES@)
[@DEFAULT@]: '),
Line 82: prompt=True,
Line 83: ):
Line 84: raise RuntimeError(_('Aborted by user'))
Line 85: except LookupError:
Is this raised if AIA is not there? I prefer having just a debug log to say
"AIA not found" instead of silently ignore the exception.
Line 86: pass
Line 87:
Line 88:
--
To view, visit http://gerrit.ovirt.org/17098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a602a199bac576bd9fad9e180f0ddbfa0ea5b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
