A Burden has posted comments on this change.
Change subject: engine: Validate NfsTimeo and NfsRetrans
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Even better - now I know what 'timeo' meant.
I did however comment on a separate error. It's not a big deal and can be left
as is but as 'chars' is a word in English, I thought it best to remove it.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 634: VALIDATION_STORAGE_CONNECTION_EMPTY_IQN=Target details cannot be
empty.
Line 635: VALIDATION_STORAGE_CONNECTION_EMPTY_CONNECTION=${fieldName} field
cannot be empty.
Line 636: VALIDATION_STORAGE_CONNECTION_NFS_RETRANS=NFS Retransmissions should
be between 0 and 32767
Line 637: VALIDATION_STORAGE_CONNECTION_NFS_TIMEO=NFS Timeout should be between
1 and 6000
Line 638: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Suggestion:
"Invalid tag name. Only alphanumeric, '-' and '_' characters are valid"
Line 639: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required
Line 640: VALIDATION.VM_POOLS.NUMBER_OF_MAX_ASSIGNED_VMS_OUT_OF_RANGE=Number of
max assigned VMs per user must be at least 1.
Line 641: VALIDATION.ROLES.NAME.NOT_NULL=Role name is required
Line 642: VALIDATION.ROLES.NAME.MAX=Role name must not exceed 126 characters
--
To view, visit http://gerrit.ovirt.org/17182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15d35b2547bb36d17e29c90a05854fe6f897d5d2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
