Juan Hernandez has posted comments on this change.
Change subject: core: Cache JNDI lookups and InitialContext creation
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Only one minor comment about code style, feel free to ignore it.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EJBUtilsStrategy.java
Line 50: private static InitialContext context;
Line 51:
Line 52: private static synchronized InitialContext getInitialContext()
throws NamingException {
Line 53:
Line 54: if (context == null)
Don't we have a style rule mandating the use of {} even if there is only one
statement to enclose?
Line 55: context = new InitialContext();
Line 56:
Line 57: return context;
Line 58: }
--
To view, visit http://gerrit.ovirt.org/16612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ae8d0a90a03c498e19e5429d196924671c073b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
