Allon Mureinik has posted comments on this change.
Change subject: userportal : Fix DiskForVmGuid high CPU
......................................................................
Patch Set 4: (3 inline comments)
Please see inline comments - other than that, looks good.
@Daniel - please review the frontend changes.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
Line 259:
Line 260: GetAllDisksPartialDataByVmId(VdcQueryAuthType.User),
Line 261: // Default type instead of having to null check
Line 262: Unknown(VdcQueryAuthType.User);
Line 263: ;
please remove
Line 264:
Line 265: /**
Line 266: * What kind of authorization the query requires. Although this
is essentially a <code>boolean</code>, it's
Line 267: * implemented as an enum for future extendability.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java
Line 141: public Disk mapRow(ResultSet rs, int rowNum) throws
SQLException {
Line 142: DiskImage disk = new DiskImage();
Line 143: disk.setDiskAlias(rs.getString("disk_alias"));
Line 144: disk.setSize(rs.getLong("size"));
Line 145: disk.setId(new Guid((UUID) rs.getObject("disk_id")));
use getGuid(rs, "disk_id")
Line 146:
Line 147: return disk;
Line 148: }
Line 149: }
....................................................
Commit Message
Line 9: In this patch we remove the need to load all disk data and just load the
Line 10: required information for the user portal.
Line 11:
Line 12: Bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=971237
Line 13:
Please remove the whitespace here.
Line 14: Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c
--
To view, visit http://gerrit.ovirt.org/16657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceb6e518936f65403561703e6b70920fbcc1f07c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
