Eli Mesika has uploaded a new change for review. Change subject: core: [db] moving matrialilized views function... ......................................................................
core: [db] moving matrialilized views function... core: [db] moving materialized views function to dbscustom.sh Since materialized views functionality is not common to all databases, moving this functionality to dbcustomfunctions.sh such that it can be overridden by empty functions with the same names Change-Id: I696b50dc98988f91912930b5d3777add0a2ae56d Signed-off-by: Eli Mesika <[email protected]> --- M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/dbfunctions.sh 2 files changed, 19 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/17399/1 diff --git a/packaging/dbscripts/dbcustomfunctions.sh b/packaging/dbscripts/dbcustomfunctions.sh index d6b3aba..f9ec53a 100755 --- a/packaging/dbscripts/dbcustomfunctions.sh +++ b/packaging/dbscripts/dbcustomfunctions.sh @@ -60,3 +60,22 @@ fi fi } + +# Materilized views functions, override with empty implementation on DBs that not supporting that + +install_materialized_views_func() { + execute_file "materialized_views_sp.sql" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null +} + +drop_materialized_views() { + echo "Dropping materialized views..." + CMD="select DropAllMaterializedViews();" + execute_command "${CMD}" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null +} + +refresh_materialized_views() { + echo "Refreshing materialized views..." + CMD="select RefreshAllMaterializedViews(true);" + execute_command "${CMD}" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null +} + diff --git a/packaging/dbscripts/dbfunctions.sh b/packaging/dbscripts/dbfunctions.sh index f50bac5..7761aba 100755 --- a/packaging/dbscripts/dbfunctions.sh +++ b/packaging/dbscripts/dbfunctions.sh @@ -136,24 +136,8 @@ execute_file "common_sp.sql" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null } -install_materialized_views_func() { - execute_file "materialized_views_sp.sql" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null -} - delete_async_tasks_and_compensation_data() { execute_file "delete_async_tasks_and_compensation_data.sql" ${DATABASE} ${SERVERNAME} ${PORT}> /dev/null -} - -drop_materialized_views() { - echo "Dropping materialized views..." - CMD="select DropAllMaterializedViews();" - execute_command "${CMD}" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null -} - -refresh_materialized_views() { - echo "Refreshing materialized views..." - CMD="select RefreshAllMaterializedViews(true);" - execute_command "${CMD}" ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null } run_pre_upgrade() { -- To view, visit http://gerrit.ovirt.org/17399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I696b50dc98988f91912930b5d3777add0a2ae56d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
