Shubhendu Tripathi has posted comments on this change. Change subject: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao ......................................................................
Patch Set 8: (1 inline comment) .................................................... File packaging/dbscripts/network_sp.sql Line 549: Line 550: Create or replace FUNCTION GetMacsByDataCenterId(v_data_center_id UUID) RETURNS SETOF varchar Line 551: AS $procedure$ Line 552: BEGIN Line 553: RETURN QUERY SELECT mac_addr Add formatting so code is more redable Line 554: FROM vm_interface Line 555: WHERE EXISTS ( Line 556: SELECT 1 FROM vm_static Line 557: JOIN vds_groups ON vm_static.vds_group_id = vds_groups.vds_group_id -- To view, visit http://gerrit.ovirt.org/17179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea17ab1f7b686c5674b33b353794456450719f8f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
