Allon Mureinik has posted comments on this change.
Change subject: restapi: add storage server connections resource
......................................................................
Patch Set 26: Looks good to me, but someone else must approve
(2 inline comments)
+1 on the backend side
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
Line 29: }
Line 30:
Line 31: @Override
Line 32: public Storage update(Storage connection) {
Line 33: validateParameters(connection, "host.id|name");
once http://gerrit.ovirt.org/#/c/17288/ is merged, we should remove
host.id|name from here.
Line 34: validateEnums(Storage.class, connection);
Line 35: return performUpdate(connection,
Line 36: new
QueryIdResolver<String>(VdcQueryType.GetStorageServerConnectionById,
Line 37:
StorageServerConnectionQueryParametersBase.class),
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
Line 53: }
Line 54:
Line 55: @Override
Line 56: public Response add(Storage storage) {
Line 57: validateParameters(storage, "address", "type", "host.id|name");
once http://gerrit.ovirt.org/#/c/17288/ is merged, host.id|name should be
removed
Line 58: // map to backend object
Line 59: StorageServerConnections storageConnection =
Line 60: getMapper(Storage.class,
StorageServerConnections.class).map(storage, null);
Line 61: Guid hostId = getHostId(storage.getHost());
--
To view, visit http://gerrit.ovirt.org/16617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6bc32ead098390723825872f6fb292097d52835
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
