Kanagaraj M has posted comments on this change.
Change subject: backend: ExportRepoImageParameters default constructor
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportRepoImageParameters.java
Line 9: private Guid destinationDomainId;
Line 10:
Line 11: @SuppressWarnings("unused")
Line 12: public ExportRepoImageParameters() {
Line 13: super();
I feel the call to super() is not required, as it is always done implicitly.
Line 14: }
Line 15:
Line 16: public ExportRepoImageParameters(Guid imageId) {
Line 17: super(imageId);
--
To view, visit http://gerrit.ovirt.org/17342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63556883c8d81ce3914feac5a76d102d3964c678
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
