Allon Mureinik has posted comments on this change.
Change subject: restapi: [wip] image entity and import from glance
......................................................................
Patch Set 1: (2 inline comments)
I''m wondering if modeling RepoImage as Image won't confuse us with the Image
business entity.
thought from the other esteemed reviewers?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
Line 25: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase;
Line 26: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 27: import org.ovirt.engine.core.compat.Guid;
Line 28:
Line 29: import static
org.ovirt.engine.api.restapi.resource.BackendDataCenterResource.getStoragePools;
This should be on the top
Line 30:
Line 31:
Line 32: public abstract class AbstractBackendActionableResource <R extends
BaseResource, Q /* extends IVdcQueryable */ >
Line 33: extends AbstractBackendSubResource<R, Q> {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java
Line 50:
Line 51: if (selectedQuota != null) {
Line 52: importParameters.setQuotaId(selectedQuota.getId());
Line 53: }
Line 54: */
please remove the commented out code
Line 55: return doAction(VdcActionType.ImportRepoImage,
importParameters, action);
Line 56: }
Line 57:
Line 58: @Override
--
To view, visit http://gerrit.ovirt.org/17348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9104ff0eba175c90b42bc5651ada0f688eeb00
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
