Daniel Erez has posted comments on this change.

Change subject: UI: Using unique icon when host is turned to 
PreparingForMaintenance status
......................................................................


Patch Set 1: (4 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-07-29 18:53:37 +0300
Line 4: Commit:     Yaniv Bronhaim <[email protected]>
Line 5: CommitDate: 2013-07-29 18:53:37 +0300
Line 6: 
Line 7: UI: Using unique icon when host is turned to PreparingForMaintenance
s/UI/webadmin
Line 8: status
Line 9: 
Line 10: Change-Id: Iacae2d58feab5c30813a1d8383ca1abdb356ca5d
Line 11: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960749


Line 7: UI: Using unique icon when host is turned to PreparingForMaintenance
Line 8: status
Line 9: 
Line 10: Change-Id: Iacae2d58feab5c30813a1d8383ca1abdb356ca5d
Line 11: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=960749
remove url


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
Line 362: 
Line 363:     @Source("images/vmStatus/vm_freeze.png")
Line 364:     ImageResource frozenImage();
Line 365: 
Line 366:     @Source("images/icon_host_prepare_to_migrate.png")
remove the 'icon_' prefix
Line 367:     ImageResource prepareImage();


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java
Line 35:         case Down:
Line 36:             statusImage = resources.downImage();
Line 37:             break;
Line 38:         case PreparingForMaintenance:
Line 39:             statusImage = resources.prepareImage();
add 'break;'
Line 40:         case Maintenance:
Line 41:             statusImage = resources.maintenanceImage();
Line 42:             break;
Line 43:         case Up:


-- 
To view, visit http://gerrit.ovirt.org/17430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacae2d58feab5c30813a1d8383ca1abdb356ca5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to