Maor Lipchuk has posted comments on this change.
Change subject: core: Fix HooksParser javadoc
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
see extra space minor comment
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vdshooks/VdsHooksParser.java
Line 3: import java.util.HashMap;
Line 4: import java.util.Map;
Line 5:
Line 6: /**
Line 7: * Parsers a hooks string to a map of script directories/events to a
map of script names to a
extra space before map
besides that, this comment is so unreadable I would even consider to remove it
at all
parsers a .. to a... to a... to a...
Line 8: * map of script properties.
Line 9: * The string is in format of a "toString" invocation on java.util.map
object - for
Line 10: * example
"{before_vm_hibernate={myscript.sh={md5=5d9c4609cd936e80bac8c9ef7b27ea73},
Line 11: * 01_log={md5=f388923356e84c2b4149572a44fde2b4}},
--
To view, visit http://gerrit.ovirt.org/16816
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd8c46a83aba4bd4386cb0c0a7288c0df6f0a9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
