Alon Bar-Lev has posted comments on this change.

Change subject: tools: Add script to dump heap
......................................................................


Patch Set 4:

Added arguments and defaults, so we can dump notifier or any other java 
process. Removed the multiple su, remove the comment-per-trivial-statement as 
we end up fixing comments and not code. Removed the alternate process name, as 
in 3.3 the process name will be the same upstream/downstream.

jmap fails for me (java-1.7.0-openjdk-devel-1.7.0.25-2.3.10.3.fc17.x86_64):

 Caused by: sun.jvm.hotspot.utilities.AssertionFailure: Expecting 
GenCollectedHeap, G1CollectedHeap, or ParallelScavengeHeap, but got 
sun.jvm.hotspot.gc_interface.CollectedHeap

-- 
To view, visit http://gerrit.ovirt.org/15359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ea3355eafbb07d2b6c9594abcc282c139d2f31f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to