Laszlo Hornyak has posted comments on this change.
Change subject: [WIP] restapi: Add VM.cpuShares attribute to the API
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
The change in RunVmParams should probably be moved to a prev patch in the set,
since it is not used here and it is backend code
looks correct anyway
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
Line 213: }
Line 214:
Line 215: public void setBalloonEnabled(boolean isBalloonEnabled) {
Line 216: this.balloonEnabled = isBalloonEnabled;
Line 217: }
a little code formatting here please
Line 218: public int getCpuShares() {
Line 219: return cpuShares;
Line 220: }
Line 221:
--
To view, visit http://gerrit.ovirt.org/17462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb42d5b132bcf7718f4c8e6162bbbc916ac24b99
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
