Sandro Bonazzola has uploaded a new change for review. Change subject: upload: nfs: set correct umask while renaming ......................................................................
upload: nfs: set correct umask while renaming set the correct umask while renaming the temporary file to destination file. Avoid to have incorrect access bits on systems with not standard umask (like 077) Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503 Bug-Url: https://bugzilla.redhat.com/990144 Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/__main__.py 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-iso-uploader refs/changes/85/17485/1 diff --git a/src/__main__.py b/src/__main__.py index a27af14..d530ca3 100644 --- a/src/__main__.py +++ b/src/__main__.py @@ -731,7 +731,7 @@ """ retVal = True logging.debug("euid(%s) egid(%s)" % (os.geteuid(), os.getegid())) - umask_save = os.umask(0137) # Set to 660 + umask_save = os.umask(0137) # Set to 640 try: src = open(src_file_name, 'r') os.setegid(gid) @@ -758,6 +758,7 @@ NFS mount. """ logging.debug("euid(%s) egid(%s)" % (os.geteuid(), os.getegid())) + umask_save = os.umask(0137) # Set to 640 try: os.setegid(gid) os.seteuid(uid) @@ -768,6 +769,7 @@ finally: os.seteuid(0) os.setegid(0) + os.umask(umask_save) def rename_file_ssh(self, user, address, src_file_name, dest_file_name): """ -- To view, visit http://gerrit.ovirt.org/17485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
