Eli Mesika has uploaded a new change for review. Change subject: core:[ExternalTasks] Cannot add sub-step under... ......................................................................
core:[ExternalTasks] Cannot add sub-step under... [ExternalTasks] Cannot add sub-step under existing (parent) step 1) Fixing mandatory parameters step.parentStep.id => parentStep.id 2) Adding handling to the add method to inject the step parent Change-Id: Ibc610d6f295a688ceec1b038107c07d43390b431 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988082 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/17488/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java index c169573..ae6dda3 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java @@ -42,16 +42,19 @@ validateParameters(step, "type", "status.state" , "description"); String id; if (step.isSetParentStep()) { - validateParameters(step, "step.parentStep.id"); + validateParameters(step, "parentStep.id"); id = step.getParentStep().getId(); } else { id = jobId.toString(); } - return performCreate(VdcActionType.AddExternalStep, + Response response = performCreate(VdcActionType.AddExternalStep, new AddExternalStepParameters(asGuid(id), step.getDescription(),StepMapper.map(StepEnum.fromValue(step.getType())), JobMapper.map(step.getStatus(), null)), new QueryIdResolver<Guid>(VdcQueryType.GetStepByStepId, IdQueryParameters.class)); + Step createdStep = (Step)response.getEntity(); + injectParent(createdStep); + return response; } @Override -- To view, visit http://gerrit.ovirt.org/17488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc610d6f295a688ceec1b038107c07d43390b431 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
