Federico Simoncelli has posted comments on this change.
Change subject: core: do not clear currently running tasks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java
Line 130: synchronized (_listTasks) {
Line 131: java.util.ArrayList<CommandAsyncTask>
CurrentActionTypeTasks = getCurrentTasks();
Line 132:
Line 133: for (CommandAsyncTask task : CurrentActionTypeTasks) {
Line 134: if (task.getLastTaskStatus().getStatus() ==
AsyncTaskStatusEnum.finished
I need to remove also "aborting" as well. Only case that I have to cover is
"finished". From the vdsm code:
DEPRECATED_STATE = {
...
finished: "finished",
recovered: "finished",
failed: "finished"
}
_done = [finished, recovered, failed]
def isDone(self):
return self.state in self._done
def deprecated_getStatus(self):
...
oReturn["taskState"] = self.state.DEPRECATED_STATE[self.state.state]
...
Line 135: || task.getLastTaskStatus().getStatus() ==
AsyncTaskStatusEnum.aborting) {
Line 136: task.clearAsyncTask();
Line 137: }
Line 138: }
--
To view, visit http://gerrit.ovirt.org/17343
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I230723796721d2cfd639be9f4a405fb54ef63e2f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
