Alon Bar-Lev has uploaded a new change for review. Change subject: core: reduce the use of lists ......................................................................
core: reduce the use of lists Change-Id: I20ea91d7020596b4bf49b620e4a789a3a94eaf5f Reported-By: Antoni Segura Puimedon <[email protected]> Signed-off-by: Alon Bar-Lev <[email protected]> --- M src/plugins/ovirt-host-deploy/core/misc.py M src/plugins/ovirt-host-deploy/core/offlinepackager.py M src/plugins/ovirt-host-deploy/gluster/packages.py M src/plugins/ovirt-host-deploy/vdsm/bridge.py M src/plugins/ovirt-host-deploy/vdsm/packages.py 5 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-host-deploy refs/changes/98/17498/1 diff --git a/src/plugins/ovirt-host-deploy/core/misc.py b/src/plugins/ovirt-host-deploy/core/misc.py index caabb77..4f7e5ac 100644 --- a/src/plugins/ovirt-host-deploy/core/misc.py +++ b/src/plugins/ovirt-host-deploy/core/misc.py @@ -45,10 +45,10 @@ @plugin.event( stage=plugin.Stages.STAGE_BOOT, - before=[ + before=( otopicons.Stages.CORE_LOG_INIT, otopicons.Stages.CORE_CONFIG_INIT, - ], + ), ) def _preinit(self): self.environment.setdefault( diff --git a/src/plugins/ovirt-host-deploy/core/offlinepackager.py b/src/plugins/ovirt-host-deploy/core/offlinepackager.py index 84fddf5..c67dcb5 100644 --- a/src/plugins/ovirt-host-deploy/core/offlinepackager.py +++ b/src/plugins/ovirt-host-deploy/core/offlinepackager.py @@ -44,7 +44,7 @@ pass def queryPackages(self, patterns=None): - if patterns == ['vdsm']: + if tuple(patterns) == ('vdsm',): return [ { 'operation': 'installed', @@ -64,9 +64,9 @@ @plugin.event( stage=plugin.Stages.STAGE_INIT, - after=[ + after=( otopicons.Stages.PACKAGERS_DETECTION, - ], + ), ) def _init(self): if self.environment.setdefault( diff --git a/src/plugins/ovirt-host-deploy/gluster/packages.py b/src/plugins/ovirt-host-deploy/gluster/packages.py index 24f0cdd..1fecfda 100644 --- a/src/plugins/ovirt-host-deploy/gluster/packages.py +++ b/src/plugins/ovirt-host-deploy/gluster/packages.py @@ -60,7 +60,7 @@ ), ) def _validation(self): - if not self.packager.queryPackages(patterns=['vdsm-gluster']): + if not self.packager.queryPackages(patterns=('vdsm-gluster',)): raise RuntimeError( _( 'Cannot locate gluster packages, ' diff --git a/src/plugins/ovirt-host-deploy/vdsm/bridge.py b/src/plugins/ovirt-host-deploy/vdsm/bridge.py index 8c2b561..3789d62 100644 --- a/src/plugins/ovirt-host-deploy/vdsm/bridge.py +++ b/src/plugins/ovirt-host-deploy/vdsm/bridge.py @@ -595,7 +595,7 @@ stage=plugin.Stages.STAGE_INTERNAL_PACKAGES, ) def _internal_packages(self): - self.packager.install(packages=['iproute']) + self.packager.install(packages=('iproute',)) @plugin.event( stage=plugin.Stages.STAGE_VALIDATION, diff --git a/src/plugins/ovirt-host-deploy/vdsm/packages.py b/src/plugins/ovirt-host-deploy/vdsm/packages.py index d80040f..2f09e7c 100644 --- a/src/plugins/ovirt-host-deploy/vdsm/packages.py +++ b/src/plugins/ovirt-host-deploy/vdsm/packages.py @@ -68,7 +68,7 @@ stage=plugin.Stages.STAGE_VALIDATION, ) def _validation(self): - result = self.packager.queryPackages(patterns=['vdsm']) + result = self.packager.queryPackages(patterns=('vdsm',)) if not result: raise RuntimeError( _( -- To view, visit http://gerrit.ovirt.org/17498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20ea91d7020596b4bf49b620e4a789a3a94eaf5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
