Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: no need for both %dir and directory in %files ......................................................................
Patch Set 1: (1 inline comment) .................................................... File ovirt-engine.spec.in Line 682 Line 683 Line 684 Line 685 Line 686 Ok, ignore my previous comment: I've read http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html#S3-RPM-INSIDE-DIR-DIRECTIVE and it's correct to avoid %dir here, we don't want just the directory but the whole content. Looking at https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Unversioned it seems that the recommended way for having the directory and the whole content is having a trailing /. -- To view, visit http://gerrit.ovirt.org/17514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da475c83ec94d00084940aa856647e52d4f39d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
