Michal Skrivanek has posted comments on this change.

Change subject: [wip] engine: external scheduler integration
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 250:             return false;
Line 251:         }
Line 252:         return true;
Line 253:     }
Line 254: 
is this controllable? i.e. in case we need to prove a slowness is caused by 
externally modified/supplied scripts we would disable external scheduling 
completely
Line 255:     protected List<VDS> runExternalFilters(List<VDS> vdsList, 
Map<String, Object> parameters, List<String> messages) {
Line 256:         String extSchedUrl = 
Config.GetValue(ConfigValues.ExternalSchedulerServiceURL);
Line 257:         XmlRpcClientConfigImpl config = new XmlRpcClientConfigImpl();
Line 258:         config.setConnectionTimeout((Integer) 
Config.GetValue(ConfigValues.ExternalSchedulerConnectionTimeout));


-- 
To view, visit http://gerrit.ovirt.org/17501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b6660beb319df0afe569f31c16033bf6192df9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to