Maor Lipchuk has posted comments on this change.
Change subject: core: Add storage validation when plugging an image.
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 97: if (isImageDisk && getStoragePoolIsoMapDao().get(new
StoragePoolIsoMapId(
Line 98: ((DiskImage) disk).getStorageIds().get(0),
getVm().getStoragePoolId())) == null) {
Line 99: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_MATCH);
Line 100: }
Line 101: if (isImageDisk) {
we should not add an empty line after curly bracket, only before a comment IMHO
Line 102: StorageDomain storageDomain =
getStorageDomainDAO().getForStoragePool(
Line 103: ((DiskImage) disk).getStorageIds().get(0),
((DiskImage) disk).getStoragePoolId());
Line 104: StorageDomainValidator storageDomainValidator = new
StorageDomainValidator(storageDomain);
Line 105: if
(!validate(storageDomainValidator.isDomainExistAndActive())) {
Line 104: StorageDomainValidator storageDomainValidator = new
StorageDomainValidator(storageDomain);
Line 105: if
(!validate(storageDomainValidator.isDomainExistAndActive())) {
Line 106: return false;
Line 107: }
Line 108: }
see previous comment
Line 109: DiskValidator diskValidator = new DiskValidator(disk);
Line 110: if (!validate(diskValidator.isVirtIoScsiValid(getVm()))) {
Line 111: return false;
Line 112: }
--
To view, visit http://gerrit.ovirt.org/17170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
