Maor Lipchuk has posted comments on this change.
Change subject: core: Removing a storage connection without a VDS
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
Line 106: @Override
Line 107: protected void executeCommand() {
Line 108: String connectionId = getConnection().getid();
Line 109: getStorageServerConnectionDao().remove(connectionId);
Line 110: log.debugFormat("Removing connection %s from database ",
connectionId);
I think it should be here {0}
Line 111: if (Guid.isNullOrEmpty(getParameters().getVdsId())) {
Line 112: log.debug("No vdsId passed - hosts will not be
disconnected.");
Line 113: } else {
Line 114: // disconnect the connection from vdsm
--
To view, visit http://gerrit.ovirt.org/17531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ddcf6cb6cd2aed85c23f0e7565ab0b597474a81
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
