Omer Frenkel has posted comments on this change.
Change subject: restapi: cloud-init [6/6] - rest api for start vm
......................................................................
Patch Set 1: (11 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2086: </xs:annotation>
Line 2087: </xs:element>
Line 2088: </xs:sequence>
Line 2089: </xs:complexType>
Line 2090:
Done
Line 2091: <xs:complexType name="CloudInit">
Line 2092: <xs:sequence>
Line 2093: <xs:element name="hostname" type="xs:string" minOccurs="0"/>
Line 2094: <xs:element name="network" minOccurs="0">
Line 2089: </xs:complexType>
Line 2090:
Line 2091: <xs:complexType name="CloudInit">
Line 2092: <xs:sequence>
Line 2093: <xs:element name="hostname" type="xs:string" minOccurs="0"/>
Done
Line 2094: <xs:element name="network" minOccurs="0">
Line 2095: <xs:complexType>
Line 2096: <xs:sequence>
Line 2097: <xs:element name="interfaces" minOccurs="0">
Line 2093: <xs:element name="hostname" type="xs:string" minOccurs="0"/>
Line 2094: <xs:element name="network" minOccurs="0">
Line 2095: <xs:complexType>
Line 2096: <xs:sequence>
Line 2097: <xs:element name="interfaces" minOccurs="0">
Done
Line 2098: <xs:complexType>
Line 2099: <xs:sequence>
Line 2100: <xs:element name="interface" minOccurs="0"
maxOccurs="unbounded">
Line 2101: <xs:complexType>
Line 2111: </xs:element>
Line 2112: </xs:sequence>
Line 2113: </xs:complexType>
Line 2114: </xs:element>
Line 2115: <xs:element name="dns_servers" minOccurs="0">
Done
Line 2116: <xs:complexType>
Line 2117: <xs:sequence>
Line 2118: <xs:element name="dns_server" type="xs:string"
minOccurs="0" maxOccurs="unbounded"/>
Line 2119: </xs:sequence>
Line 2128: </xs:element>
Line 2129: </xs:sequence>
Line 2130: </xs:complexType>
Line 2131: </xs:element> <!-- </network> -->
Line 2132: <xs:element name="authorized_keys" minOccurs="0">
Done
Line 2133: <xs:complexType>
Line 2134: <xs:sequence>
Line 2135: <xs:element name="authorized_key" minOccurs="0"
maxOccurs="unbounded">
Line 2136: <xs:complexType>
Line 2135: <xs:element name="authorized_key" minOccurs="0"
maxOccurs="unbounded">
Line 2136: <xs:complexType>
Line 2137: <xs:simpleContent>
Line 2138: <xs:extension base="xs:string">
Line 2139: <xs:attribute name="user" type="xs:string"
use="required"/>
even if i only need/expect user name here?
Line 2140: </xs:extension>
Line 2141: </xs:simpleContent>
Line 2142: </xs:complexType>
Line 2143: </xs:element>
Line 2145: </xs:complexType>
Line 2146: </xs:element>
Line 2147: <xs:element name="regenerate_ssh_keys" type="xs:boolean"
minOccurs="0"/>
Line 2148: <xs:element name="timezone" type="xs:string" minOccurs="0"/>
Line 2149: <xs:element name="passwords" minOccurs="0">
Done
Line 2150: <xs:complexType>
Line 2151: <xs:sequence>
Line 2152: <xs:element name="password" minOccurs="0"
maxOccurs="unbounded">
Line 2153: <xs:complexType>
Line 2152: <xs:element name="password" minOccurs="0"
maxOccurs="unbounded">
Line 2153: <xs:complexType>
Line 2154: <xs:simpleContent>
Line 2155: <xs:extension base="xs:string">
Line 2156: <xs:attribute name="user" type="xs:string"
use="required"/>
Done
Line 2157: </xs:extension>
Line 2158: </xs:simpleContent>
Line 2159: </xs:complexType>
Line 2160: </xs:element>
Line 2160: </xs:element>
Line 2161: </xs:sequence>
Line 2162: </xs:complexType>
Line 2163: </xs:element>
Line 2164: <xs:element name="files" minOccurs="0">
not sure about this one, path and encoding are not relevant for payload, it can
confuse users that will set it and will not get what they expected, but i don't
mind changing it, if you still think its better
Line 2165: <xs:complexType>
Line 2166: <xs:sequence>
Line 2167: <xs:element name="file" minOccurs="0"
maxOccurs="unbounded">
Line 2168: <xs:complexType>
Line 2189: <xs:element name="initialization" type="Initialization"/>
Line 2190:
Line 2191: <xs:complexType name="Initialization">
Line 2192: <xs:choice>
Line 2193: <xs:element name="cloud-init" type="CloudInit" minOccurs="0"/>
Done
Line 2194: </xs:choice>
Line 2195: </xs:complexType>
Line 2196:
Line 2197: <xs:complexType name="VmPlacementPolicy">
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 234: version.setAttachmentTypes(new AttachmentTypes());
Line 235: for (AttachmentType mode : values) {
Line 236:
version.getAttachmentTypes().getAttachmentTypes().add(mode.value());
Line 237: }
Line 238: }
Done
Line 239: }
Line 240:
Line 241: private void addCpuModes(VersionCaps version, CpuMode[] values) {
Line 242: if (VersionUtils.greaterOrEqual(version, VERSION_3_2)) {
--
To view, visit http://gerrit.ovirt.org/15537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
