David Caro has posted comments on this change.
Change subject: Appending PYTHONPATH instead of overriding it
......................................................................
Patch Set 4: Fails
(2 inline comments)
It is still failing the tests but I'm not sure why.
When starting the scheduler it prompts the line
unexpected EOF while parsing (<unknown>, line 0)
And the java code promts the results:
Tests in error:
testFilter(org.ovirt.schedulerproxy.SchedulerProxyTest): <type
'exceptions.TypeError'>:'NoneType' object is not iterable
testBalance(org.ovirt.schedulerproxy.SchedulerProxyTest): Failed to parse
server's response: Unknown type: nil
....................................................
File Makefile
Line 1: all: test pep8
Line 2:
Line 3: test:
Line 4: PYTHONPATH=src:$(PYTHONPATH) nosetests -v
This way it also uses the environment PYTHONPATH if any, but only as a second
choice (first loads from src if able)
Line 5: make start
Line 6: cd tests/java && mvn clean install
Line 7: make stop
Line 8:
....................................................
File src/oschedproxyd.py
Line 67:
Line 68: # TODO make by config
Line 69: logging.info("Loading modules")
Line 70: self._handler = RequestHandler(
Line 71: os.path.join(os.path.dirname(__file__) + '/../',
"plugins"),
Is a lot less problematic like this, it was complaining because it did not find
the correct path.
Line 72: os.getcwd())
Line 73:
Line 74: def run(self):
Line 75: logging.info("Loading modules")
--
To view, visit http://gerrit.ovirt.org/17543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dee7a560f66961402f07a7273ca38768108d371
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: David Caro <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
