Michael Pasternak has posted comments on this change.
Change subject: core, restapi: add GetVmOvfConfigurationQuery
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java
Line 150: new IdQueryParameters(guid));
Line 151: if (queryReturnValue.getSucceeded() &&
queryReturnValue.getReturnValue() != null) {
Line 152: model.setInitialization(new Initialization());
Line 153: model.getInitialization().setConfiguration(new
Configuration());
Line 154:
model.getInitialization().getConfiguration().setData((String)queryReturnValue.getReturnValue());
please move this to the corresponding mapper
Line 155:
model.getInitialization().getConfiguration().setType(ConfigurationType.OVF.name());
Line 156: }
Line 157:
Line 158: return model;
Line 151: if (queryReturnValue.getSucceeded() &&
queryReturnValue.getReturnValue() != null) {
Line 152: model.setInitialization(new Initialization());
Line 153: model.getInitialization().setConfiguration(new
Configuration());
Line 154:
model.getInitialization().getConfiguration().setData((String)queryReturnValue.getReturnValue());
Line 155:
model.getInitialization().getConfiguration().setType(ConfigurationType.OVF.name());
please call .value() cause all emumns have to be exposed in lowerecase
Line 156: }
Line 157:
Line 158: return model;
Line 159: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java
Line 67: new String[] { "Id" },
Line 68: new Object[] { SNAPSHOT_ID },
Line 69: new String());
Line 70: control.replay();
Line 71: verifyModel(resource.get(), 1);
please validated OVF content in the actual response from the resource.get()
Line 72: }
Line 73:
Line 74: @Test
Line 75: //empty list of snapshots returned from Backend.
--
To view, visit http://gerrit.ovirt.org/16176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46340c4461b57a4c314fb50ca9c19ac5fd08a451
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
