Michael Pasternak has posted comments on this change.
Change subject: core, restapi: Introducing ImportVmFromConfigurationCommand
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 401:
version.getStorageTypes().getStorageTypes().add(type.value());
Line 402: }
Line 403: }
Line 404:
Line 405: private void addConfigurationTypes(VersionCaps version,
List<ConfigurationType> types) {
1. please expose it only when: VersionUtils.greaterOrEqual(version, VERSION_3_3)
2. please call this method from generateVersionCaps()
Line 406: version.setConfigurationTypes(new ConfigurationTypes());
Line 407: for (ConfigurationType type : types) {
Line 408:
version.getConfigurationTypes().getConfigurationTypes().add(type.value());
Line 409: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 194: "");
Line 195:
Line 196: VmMapper.map(vm, vmConfiguration.getStaticData());
Line 197:
Line 198: Guid clusterId = namedCluster(vm) ? getClusterId(vm) :
Guid.createGuidFromString(vm.getCluster().getId());
please call to asGuid() isntead of Guid.createGuidFromString()
Line 199: ImportVmParameters parameters = new ImportVmParameters();
Line 200: parameters.setVm(vmConfiguration);
Line 201: parameters.setVdsGroupId(clusterId);
Line 202: return performCreate(VdcActionType.ImportVmFromConfiguration,
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ConfigurationValidator.java
Line 8: @ValidatedClass(clazz = Configuration.class)
Line 9: public class ConfigurationValidator implements Validator<Configuration>{
Line 10: @Override
Line 11: public void validateEnums(Configuration configuration) {
Line 12: if (configuration != null && configuration.getType() != null) {
please use configuration.isSetConfiguration()
Line 13: validateEnum(ConfigurationType.class,
configuration.getType(), true);
Line 14: }
Line 15: }
--
To view, visit http://gerrit.ovirt.org/15894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
