Martin Peřina has posted comments on this change.
Change subject: core: Fix compareTo for SRV records
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/tools/src/test/java/org/ovirt/engine/core/utils/dns/DnsSRVLocatorTest.java
Line 41: }
Line 42:
Line 43: @Test
Line 44: public void testZeroPriorities() throws Exception {
Line 45: DnsSRVLocator locator = mockLocator("example.com",
I know that you cannot run old and new method within the same test. So these
steps make sense for me:
1) Create a test method with data that failed old compareTo method
2) Create a new compareTo method
3) Prove that test method doesn't fail with new compareTo method
But I don't see a reason why to split these steps into several patches
Line 46: "10 100 389 a.example.com.",
Line 47: "10 100 389 b.example.com.",
Line 48: "10 100 389 c.example.com.",
Line 49: "10 100 389 d.example.com.",
--
To view, visit http://gerrit.ovirt.org/17049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff93a85f529633934515015653c517500bf51c6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
