Alon Bar-Lev has posted comments on this change.

Change subject: pki: Add a script to extract parts of a PKCS#12 store
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File packaging/bin/pki-pkcs12-extract.sh
Line 1: #!/bin/sh
fix location is good for the internal processing not for the export... I expect 
people know where to export. As this is utility anyway... and the suffix of 
nopass is more like a hack.
Line 2: 
Line 3: extractkey() {
Line 4:         local name="$1"
Line 5:         local pass="$2"


Line 44:                        NAME="${v}"
Line 45:                ;;
Line 46:                --password=*)
Line 47:                        PASSWORD="${v}"
Line 48:                ;;
input password?

output files?
Line 49:                --help)
Line 50:                        usage
Line 51:                        exit 0
Line 52:                ;;


-- 
To view, visit http://gerrit.ovirt.org/17562
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to