Michael Pasternak has posted comments on this change.
Change subject: core: osinfo - Rmove unassigned and streamline all ids with the
REST ids.
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/EnumValidator.java
Line 90: }
Line 91: }
Line 92:
Line 93: public static <E extends Enum<E>> String validateEnum(String
reason, String detail, Class<E> clz,Set<String> externalValues, String name,
boolean toUppercase) {
Line 94: if (externalValues.contains(name)) {
are externalValues all in lowercase? cause "name" is always in lowercase, i
think you should use
"toUppercase ? name.toUpperCase() : name"
as you did bellow for enum
Line 95: return name;
Line 96: }
Line 97:
Line 98: try {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 341: }
Line 342:
Line 343: private void addOsTypes(VersionCaps version) {
Line 344: version.setOsTypes(new OsTypes());
Line 345:
version.getOsTypes().getOsTypes().addAll(OsTypeUtils.getAllValues());
this addOsTypes() method called in all versions of the /capabilities resource,
you should be creating differentiation between older versions and VERSION_3_3
where new OSs became supported
Line 346: }
Line 347:
Line 348: private void addNfsVersions(VersionCaps version, NfsVersion[]
nfsVersions) {
Line 349: if (VersionUtils.greaterOrEqual(version, VERSION_3_1)) {
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
Line 272: entity.getInitrdUrl() != null ||
Line 273: entity.getKernelParams() != null) {
Line 274: OperatingSystem os = new OperatingSystem();
Line 275:
Line 276:
os.setType(SimpleDependecyInjector.getInstance().get(OsRepository.class).getUniqueOsNames().get(entity.getOsId()));
not sure what .getUniqueOsNames().get(entity.getOsId()) does, hope it maps to
old OsType values
Line 277:
Line 278: if (entity.getDefaultBootSequence() != null) {
Line 279: for (Boot boot :
VmMapper.map(entity.getDefaultBootSequence(), null)) {
Line 280: os.getBoot().add(boot);
--
To view, visit http://gerrit.ovirt.org/16679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508a8828caedf4cb8fdf971e14139404f7dded3
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
