Mike Kolesnik has posted comments on this change.
Change subject: core: Add mom policy update command
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMomPolicyCommand.java
Line 38: VdsValidator vdsValidator = new VdsValidator(getVds());
Line 39:
Line 40: return validate(vdsValidator.exists())
Line 41: && validate(vdsValidator.isUp())
Line 42: &&
validate(vdsValidator.validateMinimumVersionSupport(Version.v3_3));
Please use FeatureSupported class for the versioning checking, it's the
standard way to constrain the feature to a specific version.
Line 43: }
Line 44:
Line 45: @Override
Line 46: public List<PermissionSubject> getPermissionCheckSubjects() {
--
To view, visit http://gerrit.ovirt.org/17379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64350c17f182c1dd0ba1d06130e5d56019b32fc9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
