Mike Kolesnik has posted comments on this change.
Change subject: engine: Add audit log messages for vnic profile commands
......................................................................
Patch Set 25: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java
Line 51: }
Line 52:
Line 53: private Network getNetwork() {
Line 54: if (network == null) {
Line 55: network =
getNetworkDAO().get(getVnicProfile().getNetworkId());
Isn't this error prone if the network id is changed to non existing via update,
or a non existing one is sent when adding?
I know CDA will block it, but I think audit logging mechanism may fail later on
to log due to NPE..
Line 56: }
Line 57:
Line 58: return network;
Line 59: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 482: INVALID_INTERFACE_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
configure management network on host ${VdsName}. Host ${VdsName} has an invalid
interface ${InterfaceName} for the management network configuration.
Line 483: VLAN_ID_MISMATCH_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
configure management network on host ${VdsName}. Host ${VdsName} has an
interface ${InterfaceName} for the management network configuration with
VLAN-ID (${VlanId}), which is different from data-center definition
(${MgmtVlanId}).
Line 484: SETUP_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
configure management network on host ${VdsName} due to setup networks failure.
Line 485: PERSIST_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK=Failed to activate host
${VdsName} due to failure in persisting the management network configuration.
Line 486: ADD_VNIC_PROFILE=VM network interface profile ${VnicProfileName} was
added to network ${NetworkName} in Data Center: ${DataCenterName}.
Consider if we should also print the user name as is done in most of the
messages of this sort..
Line 487: ADD_VNIC_PROFILE_FAILED=Failed to add VM network interface profile
${VnicProfileName} to network ${NetworkName} in Data Center: ${DataCenterName}
Line 488: UPDATE_VNIC_PROFILE=VM network interface profile ${VnicProfileName}
was updated for network ${NetworkName} in Data Center: ${DataCenterName}.
Line 489: UPDATE_VNIC_PROFILE_FAILED=Failed to update VM network interface
profile ${VnicProfileName} for network ${NetworkName} in Data Center:
${DataCenterName}.
Line 490: REMOVE_VNIC_PROFILE=VM network interface profile ${VnicProfileName}
was removed from network ${NetworkName} in Data Center: ${DataCenterName}.
--
To view, visit http://gerrit.ovirt.org/16892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d41b5487faf7eafaeae0ed929fd53ad26e7416a
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
