Mike Kolesnik has posted comments on this change.
Change subject: engine: Introduce VnicProfileView and its DAO
......................................................................
Patch Set 22: Looks good to me, approved
(2 inline comments)
Please notice comments inline but not a big issue to block this from getting in
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileViewDaoDbFacadeImpl.java
Line 26: @Override
Line 27: public VnicProfileView get(Guid id, Guid userId, boolean filtered)
{
Line 28: return getCallsHandler().executeRead(getProcedureNameForGet(),
Line 29: VnicProfileViewRowMapper.INSTANCE,
Line 30: getCustomMapSqlParameterSource().addValue("id", id)
You could simply call createIdParameterMapper(Guid id) instead of the first
line..
Line 31: .addValue("user_id", userId)
Line 32: .addValue("is_filtered", filtered));
Line 33: }
Line 34:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileViewDao.java
Line 5: import
org.ovirt.engine.core.common.businessentities.network.VnicProfileView;
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7: import org.ovirt.engine.core.dao.DAO;
Line 8:
Line 9: public interface VnicProfileViewDao extends DAO {
Why not extend ReadDao?
(Since you already extending DefaultReadDaoDbFacade in the impl...)
Line 10:
Line 11: /**
Line 12: * Retrieves a vnic profile.
Line 13: *
--
To view, visit http://gerrit.ovirt.org/17018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib48832f29d0150d23d68c782be53d521628247e1
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
