Mike Kolesnik has posted comments on this change.
Change subject: engine: Add query to retrieve all vnic profiles
......................................................................
Patch Set 31: Looks good to me, approved
(1 inline comment)
Non blocker comment, but if possible please change since its a really small
change
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetAllVnicProfilesQuery.java
Line 2:
Line 3: import org.ovirt.engine.core.bll.QueriesCommandBase;
Line 4: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 5:
Line 6: public class GetAllVnicProfilesQuery<P extends IdQueryParameters>
extends QueriesCommandBase<P> {
Why IdQueryParameters?
VdcQueryParametersBase is not abstract..
Line 7: public GetAllVnicProfilesQuery(P parameters) {
Line 8: super(parameters);
Line 9: }
Line 10:
--
To view, visit http://gerrit.ovirt.org/16672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I811391b99d193b44874c3f2355ef08e0bb6e1cff
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
